chore: remove node 6 from testing env.

nordnet / nordnet-ui-kit

Nordnet UI Kit

https://nordnet.github.io/nordnet-ui-kit/

106 stars 28 forks source link

chore: remove node 6 from testing env. #506

Closed wemstad closed 5 years ago

coveralls commented 5 years ago

Coverage remained the same at 83.695% when pulling c2b59aec5ae9e535f69c2db114871dedd9397df3 on remove-old-node-version into ac710e0c5afc131e708a7bd7b09cfedbdac47919 on master.

coveralls commented 5 years ago

Coverage remained the same at 83.695% when pulling 69ffa3630899e9abbb85c5b64b5099241496c69d on remove-old-node-version into 65901810a316fb2224eaf5a9974d310464d32cf6 on master.

iamstarkov commented 5 years ago

what's up with all the changes other than removal of node 6?

wemstad commented 5 years ago

what's up with all the changes other than removal of node 6?

Autoformatting, shouldn't be there. Will fix.

End of life for node 6 is April 2019, so it is a little bit early to drop support for it. but its okay

Yeah, but I don't really see any reason for us to continue supporting it. Bleeding egde ftw!

iamstarkov commented 5 years ago

Autoformatting, shouldn't be there. Will fix.

thanks

Yeah, but I don't really see any reason for us to continue supporting it.

I agree

Bleeding egde ftw!

I disagree