search

nordnet / nordnet-ui-kit

Nordnet UI Kit
https://nordnet.github.io/nordnet-ui-kit/
106 stars 28 forks source link

chore: upgrade eslint #524

Closed JacobBlomgren closed 5 years ago

JacobBlomgren commented 5 years ago

I upgraded eslint and fixed all new lint errors. Many errors were in deprecated components, and in those cases I simply ignored them. Same for the things that would require major development work to fix. We got some a11y warnings, all related to that we don't really handle <label>s well, but that is known, and should get love in the future. I see this as more valuable for new development, to ensure that all new components are well written. Also, not to block us from updating other dependencies.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.01%) to 79.75% when pulling e8ce979edd809c21317fa766a86a0f60311e020d on bump-eslint into 378a472c6e145e0551ef19d1160d4b42042af31a on master.

nordnet-release commented 5 years ago

:tada: This PR is included in version 3.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: