chore: fix deprecated husky configs and cleanup package.json

nordnet / nordnet-ui-kit

Nordnet UI Kit

https://nordnet.github.io/nordnet-ui-kit/

106 stars 28 forks source link

chore: fix deprecated husky configs and cleanup package.json #541

Closed JacobBlomgren closed 5 years ago

JacobBlomgren commented 5 years ago

I got some husky warnings on my machine, turns out that they have changed how it's supposed to be configured https://github.com/typicode/husky#upgrading-from-014 But thankfully they had a ./node_modules/.bin/husky-upgrade so this is just a run of that and now committing and pushing works without warnings.

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

coveralls commented 5 years ago

Coverage remained the same at 79.858% when pulling c1c3af2531e22af99475eb45bdc3a1288eb4dcbb on chore/husky-deprecations into 9c2f66e9e8a36b47ae102cb19149c502d2b897c6 on master.

JacobBlomgren commented 5 years ago

why nyc config isnt needed anymore? at least it shouldnt be in this pr or change the title.

You're right. We don't use it anymore, as you can see it was removed here: https://github.com/nordnet/nordnet-ui-kit/pull/521/files but the config was forgotten behind.

nordnet-release commented 5 years ago

:tada: This PR is included in version 3.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: