search

nordnet / nordnet-ui-kit

Nordnet UI Kit
https://nordnet.github.io/nordnet-ui-kit/
106 stars 28 forks source link

feat: add a solid triangle #545

Closed mjmonline closed 5 years ago

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

mjmonline commented 5 years ago

This to replace CSS triangles

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.04%) to 79.896% when pulling 6896b1035a13678cacc579584f6934d3f2d62032 on feat/add-triangle into 77f0276e3314acc6304332b8c0372bbd7a4eca4e on master.

mjmonline commented 5 years ago

@JacobBlomgren good catch, fix pushed

JacobBlomgren commented 5 years ago

@mjmonline are you sure I can't see a commit and it's not updated here https://nordnet-ui-kit-px5q5gcmh.now.sh/#icon

mjmonline commented 5 years ago

@JacobBlomgren ahh the push failed. Check now please

JacobBlomgren commented 5 years ago

@mjmonline cool. And now I wonder another thing, sorry for the inconvenience, but if you look at SolidArrowUp, doesn't it look awfully similar?

mjmonline commented 5 years ago

@JacobBlomgren it does, but it's not a 90degree angle on the corner pointing up. Thats what design wants :)

JacobBlomgren commented 5 years ago

@mjmonline go ahead then

nordnet-release commented 5 years ago

:tada: This PR is included in version 3.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: