search

nordnet / nordnet-ui-kit

Nordnet UI Kit
https://nordnet.github.io/nordnet-ui-kit/
106 stars 28 forks source link

chore: fix babel watch and github pages publishing #566

Closed JacobBlomgren closed 5 years ago

JacobBlomgren commented 5 years ago

So we have moved fast and really improved the UI kit, but @jesperwiner and I noticed two things that had broken, the watch command, and gh pages publishing since 14 days ago. Both were easy, small fixes so I put them in the same PR.

Why didn't we notice that gh pages publishing broke, you wonder? Well, it was run in after_script, whose "exit code does not affect the build result" https://docs.travis-ci.com/user/job-lifecycle/#breaking-the-build, so the build was still marked as green.

nordnet-release commented 5 years ago

:tada: This PR is included in version 4.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: