search

nordnet / python-freeipa-json

Tiny/basic module for communicating with the FreeIPA API without having to install the entire FreeIPA toolchain
MIT License
54 stars 37 forks source link

PEP8, example #12

Open 14DF397FCA opened 4 years ago

acalm commented 4 years ago

I've lost my merge super powers, which is perfectly fine since I have no means of testing the changes and no longer associated with the owning organization. However, this PR looks good to me, except for the use of f-strings. Yes, I know it's only in the readme, it may however confuse people and promote it's usage, useful as f-stings may be, they are not backwards compatible, even within the python3 world.

14DF397FCA commented 4 years ago

It's sad story. I hope anybody with write access will merge this request)

Yes, you right about f-strings and I updated readme.