search

nordtheme / atom-ui

An arctic, north-bluish clean and elegant minimal Atom UI theme.
https://www.nordtheme.com/ports/atom-ui
MIT License
95 stars 15 forks source link

Unreadable content in markdown-preview code blocks #46

Open arcticicestudio opened 7 years ago

arcticicestudio commented 7 years ago

The color for plain text in markdown-preview code blocks is equal the background color and can therefore not be seen.

ghi-46-scrot-before

ghi-46-scrcast-before

This issuse describes a similar bug as #45.

arcticicestudio commented 7 years ago

Changed to @markdown-preview-text-color.

ghi-46-scrot-after

dpehrson commented 7 years ago

I just installed nord-atom-ui for the first time (0.10.2) and am still affected by this. Is there something else I need to do?

Beautiful theme by the way.

@arcticicestudio

arcticicestudio commented 7 years ago

Thanks for your report 👍 This is caused by the new Theming API introduced in Atom 1.13.0. I'll have to move this feature to the Nord Atom Syntax package because the new CSS selectors won't allow to override syntax highlighted elements outside of the syntax theme package itself. I also think that this should be supported by the syntax theme anyway since it styles a result of a language and is not related to parts of the UI.

I'll create a issue for it and add a @-mention so you can track the progress 😄

dpehrson commented 7 years ago

@arcticicestudio Thanks, I absolutely love the theme and am using it across everything I can.

arcticicestudio commented 7 years ago

I'll try to migrate the code to the Nord Atom UI next weekend. In the meantime you can change the ⚛️ Atom core package markdown-preview to render previews with the GitHub style as a workaround to avoid these unreadable code blocks. It can be changed in the package settings.

ghi-46-scrot-github-style

RohanChacko commented 5 years ago

I just recently installed the nord-atom-ui with the nord syntax package. But in markdown preview, any text written in code blocks is not displayed on the screen unless highlighted. Please resolve the issue. image