nordtheme / guake

An arctic, north-bluish clean and elegant Guake color theme.
https://www.nordtheme.com/ports/guake
MIT License
28 stars 5 forks source link

Upstream theme to Guake #6

Open gsemet opened 6 years ago

gsemet commented 6 years ago

Hello, I am the Guake maintainer. I would be happy to see your theme integrated directly in Guake. Do not hesitate to add it in palettes.py ! I am not sure your script still works with Guake 3 since we rely on dconf and no more gconf.

Thanks for using Guake.

arcticicestudio commented 6 years ago

Thanks for the request, I'll submit a PR to add it to palettes.py and test the install script with the latest version. Using dconf is a good decision so I can simply copy over the install script from the Nord GNOME Terminal project :smile: I think I'll keep the current script and rename it to something with -legacy so users running distros the new version isn't available yet can still install the theme.

arcticicestudio commented 6 years ago

@gsemet I've submitted Guake/guake/pull/1275 which adds Nord to the palettes.

mati865 commented 6 years ago

I believe this can be closed now.

arcticicestudio commented 6 years ago

@mati865 Thanks for your notice to clean up issues, but the install script hasn't been ported to dconf yet and this ticket will be used to track the implementation. It'll be closed automatically as soon as the associated PR is merged.