search

nordtheme / highlightjs

An arctic, north-bluish clean and elegant highlight.js theme.
https://www.nordtheme.com/ports/highlightjs
MIT License
57 stars 6 forks source link

Gulpfile #15

Open ghost opened 4 years ago

ghost commented 4 years ago

The Gulpfile has been entirely broken by Gulp 4. Here is some guidance on upgrading.

arcticicestudio commented 4 years ago

Hi @lmn8 :wave:, thanks for your contribution :+1: This shouldn't break for users of this repository as long as they don't use the anti-pattern of installing dependencies globally since the version is pinned to 3.9.1. I'd also like to align this repository with the work- and development flow of my other projects by simply using scripts instead of external tools. Actually the tasks in the Gulpfile are fairly simple and can also be achieved through one-liners in the package.json. The order and interdependence of these tasks can be aligned with packages like npm-run-all. So instead of investing time into upgrading something that'll be removed/replaced anyway we can simply adapt the workflow of e.g. the official Nord documentation and website where way more complex tasks are simply manageable with scripts.

ghost commented 4 years ago

Good to hear! I wrote nord-geshi tasks with Gulp 4, but the package.json scripts technique looks more straightforward.