search

nordtheme / jetbrains

An arctic, north-bluish clean and elegant JetBrains IDE UI and editor color theme.
https://www.nordtheme.com/ports/jetbrains
MIT License
353 stars 50 forks source link

Current line and current selection could use a bit more contrast #37

Closed axelitus closed 5 years ago

axelitus commented 6 years ago

I'm using the latest stable PHPStorm 2018.1.6 version and I think that it would be better to increase the contrast between the current line and the current selection because currently, it's hard to distinguish them: image (the selected word is function on line 36)

Also, the comments are hard to read. I think a color like the one I have set in vim would work very nicely (which is a little bit brighter): image

For it I have this setting in my .vimrc file:

let g:nord_comment_brightness = 12
arcticicestudio commented 6 years ago

Thanks for your contribution 👍 I'll see how to improve the recognizability of the selected text on the current line, maybe the selection will be brighter to stand out from the background color.

Regarding the comment color: There is arcticicestudio/nord#94 that deals with improving the contrast of comments for all port projects. It'll be implemented for this project as soon as the decision has been made.

axelitus commented 6 years ago

Awesome! Can't wait for it, so far the theme is just incredible! I'm using it everywhere: PhpStorm, Sublime Text, Vim, Gnome Terminal...

Thanks for creating it!

seraphlive commented 5 years ago

I find "snowstorm" region highlight style in the Emacs version of Nord theme looks kind of cool. I'm thinking maybe we can use that as a reference. Just not sure if it can be easily implemented in jetbrain's editors. :)

(another way may be disable current line highlight when some block of codes are selected, like in vscode)

arcticicestudio commented 5 years ago

@seraphlive Unfortunately there is no way to implement theme configurations since all definitions are simply XML and JSON files. It is not possible to implement any logic like functions for conditions based on user configurations. Emacs on the other hand are defined in Lisp so they can implement logic based on settings made by the user.

@axelitus The comment color contrast was finally increased in #41 and released in version 0.4.0. I'll close this issue for now until there is either a way to implement theme configurations or the background color of the currently active cursor line can make use of color opacity (alpha layer).

arcticicestudio commented 5 years ago

@axelitus I've submitted IDEA-215064 that requests an implementation of the highlighting feature like in VS Code: Hide the background color of the active line when selecting text.

axelitus commented 5 years ago

@arcticicestudio great to hear! Hopefully, JetBrains gets this done, as it is a nice idea that would great without messing up with the color palette. I've given it the first thumbs up!