search

nordtheme / jetbrains

An arctic, north-bluish clean and elegant JetBrains IDE UI and editor color theme.
https://www.nordtheme.com/ports/jetbrains
MIT License
354 stars 49 forks source link

Warnings are impossible to read #59

Open mojodna opened 5 years ago

mojodna commented 5 years ago

I'm not sure what name to use for this element, but it's nearly impossible to read:

image

arcticicestudio commented 5 years ago

Hi @mojodna :wave:, thanks for your contribution :+1: I've also noticed this popup a few times, but it disappeared too fast to debug it and I've currently no idea how to trigger it. I haven't found any tool in the debugging tools of the UI DevKit plugin to test this and forcing a long-running process like this is hard when your project has already bootstrapped and cached (and the machine is too fast 😄). Maybe I can reproduce it by opening a very large and heavy Java project and running IntelliJ's Clean Cache and Restart command to force a new indexing process.

Also I'm currently not sure which UI theme field is responsible for this element. I guess the Notification.ToolWindow.warningBackground key might be a good start, but there are also others like ValidationTooltip.warningBackground as well as Component.inactiveWarningFocusColor and Component.warningFocusColor.

I'll need to reproduce this to find the correct key, but I appreciate every help 😄 If you like to help you can follow Nord's plugin development guide to set up your IntelliJ to work on the Nord plugin and maybe check if you can find the correct key.

arcticicestudio commented 5 years ago

I've found the responsible key: Notification.ToolWindow.warningBackground (scheme) The problem is that IntelliJ doesn't respect the related Notification.ToolWindow.warningForeground key. Nord usesnord0 as foreground and as you can see on the screenshots that are showing the test notifications the color is correct. The notification shown on your screenshot seem to be a special notification and inherits the color of the text from another key or is indeed a bug in the IntelliJ UI component.

Current style of notifications with Nord theme

Notifications with reduced opacity (60%)

As you can see on the second screenshot the notification gets even less readable (and more ugly 😄 ) when reducing the opacity to 60%.

Therefore I'm currently blocked and think I'll open a issue in Jetbrains YouTrack (bugtracker) so they can take a look at it and maybe fix it if the style of the notification is indeed not intended like this.

mojodna commented 5 years ago

Ooh, good find. Thanks for diving into this! Nord is a sweet theme and it's nice to see that it's uncovering problems elsewhere.

ice1000 commented 4 years ago

What's the issue created on YouTrack?

arcticicestudio commented 4 years ago

@ice1000 Sorry, I've missed to add it to my task it and forgot about it later on, but created it right now: IDEA-233104.

ice1000 commented 4 years ago

Cool