nordtheme / nord

An arctic, north-bluish color palette.
https://www.nordtheme.com
MIT License
6.09k stars 170 forks source link

Port for Windows Terminal #123

Open lokesh-krishna opened 5 years ago

lokesh-krishna commented 5 years ago

Issue type: Feature

Description

Microsoft's newly announced Windows Terminal has support for themes.

Would be nice to make a Nord port for this terminal.

Potential Solution

I have a working Nord theme for Windows Terminal which could serve as the base for a proper port project.

Windows Terminal uses a json file to store the color schemes and the proposed theme has been formatted as such:

{
            "name": "Nord",
            "foreground": "#D8DEE9",
            "background": "#2E3440",
            "black": "#3B4252",
            "red": "#BF616A",
            "green": "#A3BE8C",
            "yellow": "#EBCB8B",
            "blue": "#81A1C1",
            "purple": "#B48EAD",
            "cyan": "#88C0D0",
            "white": "#E5E9F0",
            "brightBlack": "#4C566A",
            "brightRed": "#BF616A",
            "brightGreen": "#A3BE8C",
            "brightYellow": "#EBCB8B",
            "brightBlue": "#81A1C1",
            "brightPurple": "#B48EAD",
            "brightCyan": "#88C0D0",
            "brightWhite": "#E5E9F0"
        }

Anybody wishing to test this theme can simply paste this under the schemes section of their profiles.json file which is located at C:\Users\User\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\profiles.json

Resources

Documentation on color schemes for Windows Terminal: Settings Schema

Screenshots

htop

neofetch

arcticicestudio commented 5 years ago

Hi @lokesh-krishna :wave:, thanks for your contribution :+1:

I've added it to the backlog and @-mention you as soon as I start working on it so you can track the progress or contribute ideas for this port project.

Please note that it may take some time because there are many other issues over many other port projects with requests and proposals waiting in the queue. I'm currently also very busy working on the data transition of all port projects to the new and shiny website and documentations to finally have a „single source of truth“ for Nord and all related data. Please also take into account that I work as a software developer in the "real world" and I hope you understand that the time to work on my projects may vary depending on my free time. :octocat:

arcticicestudio commented 5 years ago

This is also related to a request in Nord's official Spectrum chat.

thismat commented 4 years ago

Just to chime in here, I did setup a repository for a Nord port to Windows Terminal (before I came here looking for issues, sorry).

Anyway, it's marked unofficial of course, it was a personal thing I did when I started switching all my color schemes to Nord anyway so I figured I'd put a repository up with it after not finding an official Windows Terminal port.

If you'd like me to make it private I will, I'll also take it down when the official version is up, but I also thought maybe there was something in there that can be useful to you or others here in the meantime.

Love the theme, thanks you for your work.

https://github.com/thismat/nord-windows-terminal

arcticicestudio commented 4 years ago

@thismat it's absolutely fine to create own ports of Nord 👍 There's no reason to make ports public, they are scoped to your GitHub account anyway. In fact, it's actually great to see the community creates ports. This helps other users and keeps the support for different platforms growing. These ports can also be used later on as base for official ports 😄

It's just not that good when users create a port and publish them to any kind of app/plugin/addon repository/registry/store using Nord as name. This prevents me from publishing an official port there later when the official name has already been taken, but ports in public/private GitHub/GitLab etc. repositories are totally fine.

katawajojo commented 3 years ago

Just to chime in here, I did setup a repository for a Nord port to Windows Terminal (before I came here looking for issues, sorry).

Anyway, it's marked unofficial of course, it was a personal thing I did when I started switching all my color schemes to Nord anyway so I figured I'd put a repository up with it after not finding an official Windows Terminal port.

If you'd like me to make it private I will, I'll also take it down when the official version is up, but I also thought maybe there was something in there that can be useful to you or others here in the meantime.

Love the theme, thanks you for your work.

https://github.com/thismat/nord-windows-terminal

The "white" value used in this repo is actually the color used for "brightBlack". This causes issues with things like p10k and nord-tmux expecting color 7 to be a white color.

Current Color (#4C566A) :

WindowsTerminal_2021-04-19_19-49-09

Proper Color (#E5E9F0):

WindowsTerminal_2021-04-19_19-47-35
NatoBoram commented 3 years ago

I did exactly the same as https://github.com/thismat/nord-windows-terminal yesterday here for personal use, but I'm still not satisfied.

It would be great if it an extension was published to the Windows Store. While it's infinitely more complicated, that's the kind of convenience I was looking for while making my own in the first place.

https://docs.microsoft.com/en-ca/windows/terminal/json-fragment-extensions

@arcticicestudio If I make a suitable repository with a proper, working extension, would you be able to take it so it can be made official and published under your name?

thismat commented 3 years ago

Just to chime in here, I did setup a repository for a Nord port to Windows Terminal (before I came here looking for issues, sorry). Anyway, it's marked unofficial of course, it was a personal thing I did when I started switching all my color schemes to Nord anyway so I figured I'd put a repository up with it after not finding an official Windows Terminal port. If you'd like me to make it private I will, I'll also take it down when the official version is up, but I also thought maybe there was something in there that can be useful to you or others here in the meantime. Love the theme, thanks you for your work. https://github.com/thismat/nord-windows-terminal

The "white" value used in this repo is actually the color used for "brightBlack". This causes issues with things like p10k and nord-tmux expecting color 7 to be a white color.

Current Color (#4C566A) : WindowsTerminal_2021-04-19_19-49-09

Proper Color (#E5E9F0): WindowsTerminal_2021-04-19_19-47-35

Thanks for this information. I've made the adjustments to get this working right.