search

nordtheme / tmux

An arctic, north-bluish clean and elegant tmux color theme.
https://www.nordtheme.com/ports/tmux
MIT License
1.07k stars 141 forks source link

Fix colors for tmux 2.9 #34

Closed goronfreeman closed 3 years ago

goronfreeman commented 5 years ago

tmux 2.9 removed the foo-bg, foo-fg, and foo-attr options. Here is the relevant line from the changelog:

The individual -fg, -bg and -attr options have been removed; they were superseded by -style options in tmux 1.9.

This results in broken styles in many places in nord-tmux. I updated the relevant lines to use the new foo-style syntax, and now the theme appears how it did in tmux 2.8.

jasondibenedetto commented 4 years ago

Any update on getting this merged in?

arcticicestudio commented 4 years ago

Hi @goronfreeman :wave:, thanks for your contribution :+1: Sorry for the late reply, but unfortunately my free time to spend working on OSS has been very limited in the past few months.

Since this is a breaking change I'll need to evaluate if it is possible to support both version ranges <=2.8 and >=2.9. I know they introduced a "soft deprecation" in tmux v1.9, but there were no warnings when the deprecated attributes were found in a configuration file. Introducing such a breaking change in a minor version (2.9) instead of major (3.0+) is also not the way a large project like tmux shouldn't have gone. Anyway, I'll try to test if it is possible to still provide support for both version ranges, otherwise Nord must adapt to the 2.9+ properties, raise the minimum required tmux version to 2.9 and document the breaking change in order for users to migrate to the next release version.

goronfreeman commented 4 years ago

@arcticicestudio Let me know if I can help out with that. Thanks for the details!

arcticicestudio commented 4 years ago

@goronfreeman Thanks 😄 Due to the current health situation this world has to fight with I also needed some time “off-screen“ (job, life etc.) and currently processing all the new issues & PRs in other projects, but I've moved this topic higher on my list to ensure other users are not to negatively affected by this. Maybe I'll need help when it comes to testing on other OS so I can save time setting up virtual machines again ^-^

boydkelly commented 4 years ago

Hi @goronfreeman , thanks for your contribution Sorry for the late reply, but unfortunately my free time to spend working on OSS has been very limited in the past few months.

Since this is a breaking change I'll need to evaluate if it is possible to support both version ranges <=2.8 and >=2.9. I know they introduced a "soft deprecation" in tmux v1.9, but there were no warnings when the deprecated attributes were found in a configuration file. Introducing such a breaking change in a minor version (2.9) instead of major (3.0+) is also not the way a large project like tmux shouldn't have gone. Anyway, I'll try to test if it is possible to still provide support for both version ranges, otherwise Nord must adapt to the 2.9+ properties, raise the minimum required tmux version to 2.9 and document the breaking change in order for users to migrate to the next release version.

The new syntax is valid since 1.9 as you mention above. So if the nord syntax is updated the required minimum tmux version is 1.9 and not 2.9. Cheers!

cubercsl commented 3 years ago

tmux is 3.2 now, any update for this?

ioogithub commented 2 years ago

This "breaking change" has existed for almost 2 years now. Any change that this change will be published to the main version so we can fix our systems?