search

nordtheme / vim

An arctic, north-bluish clean and elegant Vim theme.
https://www.nordtheme.com/ports/vim
MIT License
2.52k stars 274 forks source link

Underlined cursor line number in gutter #174

Closed alexandremjacques closed 4 years ago

alexandremjacques commented 5 years ago

Hi,

I'm using Nord theme for VIM 8 on iTerm2 (also using Nord theme) and recently (my guess is after the last major iTerm2 update) I noticed that my line number gutter started appearing underlined on highlight.

Screen Shot 2019-09-29 at 21 22 45

Any ideas how to resolve? I mean, remove the underline from the line number.

Regards.

arcticicestudio commented 5 years ago

Hi @alexandremjacques :wave:, thanks for your contribution :+1: Maybe this is also related to https://github.com/arcticicestudio/nord-iterm2/issues/9. I'll try to reproduce this when updating to the latest iTerm2 version.

nixtrace commented 5 years ago

This might be related to latest Vim defaulting to underline for CursorLineNr: https://github.com/vim/vim/blob/017ba07fa2cdc578245618717229444fd50c470d/src/highlight.c#L256

arcticicestudio commented 5 years ago

@nixtrace Really nice catch :tada: Comparing with the parent commit shows that the underline attribute was explicitly set for cterm. The question is if this was done on purpose or should be reported as bug. If this is a change that'll stay in Vim itself I'll update Nord Vim to explicitly disable the cterm attribute for the CursorLineNr group.

I haven't updated to the latest iTerm2 version yet (only running macOS at my job), but I guess this is superfluous now anyway. I'll also see if this is reproducible on my personal system (Arch Linux) using the latest Vim version.

nixtrace commented 5 years ago

:+1: I can see the underline on Arch and Ubuntu running Vim version 8.1.2105. Thanks!