Add basic TypeScript and improve TSX support

nordtheme / vim

An arctic, north-bluish clean and elegant Vim theme.

https://www.nordtheme.com/ports/vim

MIT License

2.51k stars 275 forks source link

Add basic TypeScript and improve TSX support #208

Closed dmshvetsov closed 4 years ago

dmshvetsov commented 4 years ago

Examples

TS

TSX

arcticicestudio commented 4 years ago

Hi @iamdidev :wave:, thanks for your contribution :+1:

This looks fantastic and seems like the plugin is able to highlight even proposal syntax features like decorators. I'll test and review the changes to get this into the ~~next~~ second next release version 🚀

dmshvetsov commented 4 years ago

Awesome! 🙌

dmshvetsov commented 4 years ago

@arcticicestudio great suggestions! 🙌

Two comments left and they are both about

hi! link tsxIntrinsicTagName htmlTag
hi! link tsxTagName tsxIntrinsicTagName

hi! link jsxTagName htmlTag

If you think a quick Zoom/Hangout call can help to find a solution to the problem I'll be happy to make that call.

dmshvetsov commented 4 years ago

@arcticicestudio thank you for all your suggestions! PR is ready for rereview.