search

nordtheme / vim

An arctic, north-bluish clean and elegant Vim theme.
https://www.nordtheme.com/ports/vim
MIT License
2.51k stars 275 forks source link

Fix: wrong group name #252

Closed kunzaatko closed 3 years ago

kunzaatko commented 3 years ago

Typo in group names: PMenuSel -> PmenuSel PMenu -> Pmenu

kunzaatko commented 3 years ago

I actually would not notice it either, if it were not for the neovim fork I was making. I have already written an e-mail to you about it, but I guess it must have disappeared in the flood of e-mails you are getting. Here it is nord.nvim. In the e-mail, I was asking whether you would maybe want to adopt it as a neovim fork, since the colour groups of neovim against vim are slowly diverging. It is an exact copy apart from it including the additional groups.

arcticicestudio commented 3 years ago

Sorry for not replying, I've moved your email into the "queue" directory, but the time to process all of them is rare 😐 I know there is currently some movement regarding the Neovim v0.5 release and its long-awaited features like TreeSitter. There are contributions like arcticicestudio/nord#157 and yours, but I need to understand what are the differences and the actual advantages between a "normal" Vim color scheme plugin and a one that is scoped to Neovim. When there are no real advantages but only satisfying the "because its new and Lua", creating an additional Neovim theme to the official Nord ports will add almost 98+% maintenance overhead.

Anyway, I'll try to find some time this weekend to post a reply in all the issues & PRs regarding this topic and also finally implement support for TreeSitter.