Closed jan-xyz closed 2 years ago
Hi @jan-xyz :wave:, thanks for your contribution :+1: Even though major version 0 means that everything can break at any time, it feels like the Neovim maintainers change names faster than their underpants 🙈
Anyway, I guess we should keep the previous groups and guard it with a Neovim version check to continue to support nvim<0.6
users, at least until the official Nord Neovim port is available.
Sounds reasonable! I will get to it as soon as possible
Please do not rush over the Christmas holidays, spending time with the family and loved ones is more important than some lines of code.
[...] we should keep the previous groups and guard it with a Neovim version check to continue to support
nvim<0.6
users, at least until the official Nord Neovim port is available.
I applied that change, and guard now the old LspDiagnostic...
highlight groups with a version check. Can you have another look?
First, happy new year 🎉🍀
Same to you! 💟
The highlight groups introduced in Neovim 0.5.0 specifically for LSP have been changed in neovim 0.6.0 to a general purpose Diagnostics API.
See: https://github.com/neovim/neovim/blob/99f6260f84a8ef94495c831155d98c330078e0ad/runtime/doc/diagnostic.txt#L187
This makes sure that Nord works with the new version of neovim. However, it keeps compatibility with the previous highlight groups used in 0.5.0.
Try it out in packer:
Thanks for taking your time and working on this <3 Jan