search

nordtheme / vim

An arctic, north-bluish clean and elegant Vim theme.
https://www.nordtheme.com/ports/vim
MIT License
2.52k stars 275 forks source link

Add support for LSPSignatureActiveParameter #286

Closed cmoscofian closed 2 years ago

cmoscofian commented 2 years ago

Currently when calling vim.lsp.buf.signature_help on a given function/method nord does not highlight or differentiate the active parameter.

This PR adds an accent color (nord8) and an underline to the current active parameter making it stand out.

Highlight group docs: https://github.com/neovim/neovim/blob/70db972e5fbcab39946ad8ac05472a693cf65b68/runtime/doc/lsp.txt#L456-L459

See it in action: Before: nord-before-zoom

After: nord-after-zoom

Live: nord-1

arcticicestudio commented 2 years ago

Hi @cmoscofian :wave:, thanks for your contribution :+1: I'll review and test the changes within the next week(s).

cmoscofian commented 2 years ago

The style looks good to me, but please move the code line into the already existing Neovim LSP block which is guarded for “vanilla” Vim users.

Yeap, no problem. Since you mentioned it I noticed that there are a few neovim specific definitions outside of that if statement, that were all introduced on version 0.5 (Diagnostics, NativeLSP and Treesitter).

Should I give a whirl at a minor refactor and just subject them all under the same specific condition checking for 0.5?

svengreb commented 2 years ago
Release Note Assets

Before

After