nordtheme / vim

An arctic, north-bluish clean and elegant Vim theme.
https://www.nordtheme.com/ports/vim
MIT License
2.51k stars 275 forks source link

Foreground of Visual selection if Also Search Highlight #293

Open iworkinpixels opened 2 years ago

iworkinpixels commented 2 years ago

I love how the search highlights look and I love how the visual selection looks, but the foreground for the search highlights is the same as the background for the visual selection, leading to search highlight text disappearing when in visual mode. I am not sure if there's a way to accomplish this, but is there a way we could cause search highlights to change their foreground color only when they are in visual mode?

Otherwise I will just have to change the color of the search highlight foreground and call it a day.

EXAMPLE:

(Search for some text):

Screen Shot 2022-03-21 at 2 38 56 PM

(Visually select a block containing search results):

Screen Shot 2022-03-21 at 2 39 08 PM
svengreb commented 1 year ago

Thank you for your patience! 🙏🏼 It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the queue in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@iworkinpixels Thanks again for your contribution!

I haven't had that case before, or I didn't pay attention to it explicitly because I was only concerned with the scope of the selection, but that's definitely not in the way how this should be styled. I guess this must be resolved by checking for the current mode and act accordingly when it is visual.

Feel free to submit a pull request or wait until it gets picked up from the queue by either me or another contributor.

hoelter commented 1 year ago

Same issue: https://github.com/nordtheme/vim/issues/347