search

nordtheme / vim

An arctic, north-bluish clean and elegant Vim theme.
https://www.nordtheme.com/ports/vim
MIT License
2.52k stars 275 forks source link

Theme does not set Terminal highlight group #337

Open vds2212 opened 1 year ago

vds2212 commented 1 year ago

This pull request intend to solve the issue: theme does not set Terminal highlight group.

Resolves #325

svengreb commented 1 year ago

Hi @vds2212 :wave:, thanks for your contribution :+1:

I'll review this PR as soon as https://github.com/nordtheme/nord/issues/185 is completed which has the most priority right now to finalize the nordtheme organization migration and finally retire Arctic Ice Studio as Nord and personal brand.

vds2212 commented 1 year ago

Thanks for your feedback. Let me know if I can be of any help.

vds2212 commented 1 year ago

I notice that the merging is blocked what can I do to unblock it :-)

vds2212 commented 1 year ago

Here is the version before the change:

Step-01

And here is the version after the change:

Step-02

svengreb commented 1 year ago

Thank you for your patience! 🙏🏼 It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the backlog in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.

@vds2212 Thanks again for your contribution 🚀 The pull request has been added to the backlog and the review will be planned for the next iterations!