search

noreasonprojects / ModernAVPlayer

ModernAVPlayer is a persistence AVPlayer wrapper
MIT License
284 stars 47 forks source link

Xcode 10 Swift 4.2 #74

Closed ArbabR closed 6 years ago

ArbabR commented 6 years ago

Hi,

After updating the pods ModernAVPlayerMedia is taking assetOptions dictionary in the constructor.

let media = ModernAVPlayerMedia(assetOptions: nil, url: liveUrl, type: .stream, isLive: true, metadata: nil)

Can you share what is assetOptions and how we can use it?

Thanks

raphrel commented 6 years ago

Hi @ArbabR,

that's the option when the AVURLAsset is init: https://developer.apple.com/documentation/avfoundation/avurlasset/1385698-init https://developer.apple.com/documentation/avfoundation/avurlasset/initialization_options

ArbabR commented 6 years ago

Hi @raphrel

Thanks understood that.

ArbabR commented 6 years ago

Hi @raphrel

I have changed the Swift version from the pods from 4 to Swift 4.2 and got 15 errors in the ModernAVPlayer as shown in attachment.

1 2
raphrel commented 6 years ago

Hi,

As I mentioned in the readme, the library is not compatible yet for swift 4.2 If you need more information, ask me.

Raphaël

ArbabR commented 6 years ago

Hi @raphrel

Thanks for reply. Got it.