search

noreiller / bootstrap-modal-carousel

A set of plugins to display a carousel into a fullscreen modal box
http://noreiller.github.com/bootstrap-modal-carousel
MIT License
128 stars 63 forks source link

bower.json outdated #20

Closed itbra closed 9 years ago

itbra commented 9 years ago

Hi, i am working to set up an assets management environment including your plugin. Installing it via bower install works. However, your bower.json file is outdated and the reason for grunt to fire the error Fatal error: Can’t detect main file for "bootstrap-modal-carousel" component. You should explicitly define it via bower_concat’s mainFiles option. See Readme for details. Checking your bower.json file i see under"main":`

"docs/css/bootstrap-modal-fullscreen.css",
"docs/css/bootstrap-carousel-fit.css",
"docs/js/bootstrap-carousel-fit.js",
"docs/js/bootstrap-modal-local.js",
"docs/js/bootstrap-modal-fullscreen.js",
"docs/js/bootstrap-modal-carousel.js"

This does not reflect your current repo setup. There is no such directory docs containing these assets. Bower retrieves this structure:

"less/carousel-fit.less",
"less/modal-fullscreen.less",
"js/carousel-fit.js",
"js/modal-carousel.js",
"js/modal-local.js",
"templates/...."

This is obviously not what is defined in bower.json. The script files deployed are also not prefixed with bootstrap- and - most important thing - the modal-fullscreen.js file is missing at all.

Would you please fix that soon?

noreiller commented 9 years ago

Hi, thanks for reporting my mistake. I just updated the bower informations with the right libs.

itbra commented 9 years ago

You're welcome. Please tell me, what happened to modal-fullscreen.js?

noreiller commented 9 years ago

Bower is just a representation of the packaged lib. If you want the source libs, modal-fulscreen.js in the src/js folder, you have to install the package as a git repo (see http://bower.io/#install-packages).

itbra commented 9 years ago

This is infact what i did when i encountered the first issue for which i opened this issue report. But, check the src folder yourself and see that there is no modal-fullscreen.js file in there. So bower won't check it out at all no matter which way i ask it to install your repo. If the file isn't there at all, it won't receive it neither way.

noreiller commented 9 years ago

The modal-fullscreen.js is part of 1.x version and the last bower version is 2.0.1. The new version supports the last version of bootstrap and the new HTML markup of the modal was easier to manipulate in CSS so modal-fullscreen.js became useless. Which version do you use in your project ?

itbra commented 9 years ago

I switched over to the latest version. However, before i started to set up my assets management environment via bower i always downloaded the *.min.js file from your repo did not watch which files it had merged. If you say it became useless then my question is answered. Just wanted to be sure, bower fetches everything correctly and won't miss any file when configuring the concatenation and uglification.

itbra commented 9 years ago

I have to come back to the bower.json issue. I tried to fetch your updated plugin via bower update first and then after this had not worked via bower install. However, it always fetches the outdated version. I guess it requires another commit and an increment of the release number as well as an update to package.json as well. As you can see your repo reflects as release number v2.0.0. Mabe this is why bower doesn't load the updated package with the fixed bower.json. Another proof for the failing update is the missing dist directory. The only directory checked out is the src directory.

I'd also suggest you also change the references for the main files to the unminified versions because these are used for building custom packages.

noreiller commented 9 years ago

I add to create a new tag for this version. The tags are now updated.