noreiller / bootstrap-modal-carousel

A set of plugins to display a carousel into a fullscreen modal box
http://noreiller.github.com/bootstrap-modal-carousel
MIT License
128 stars 63 forks source link

Configure plugin through an options object #6

Closed itbra closed 10 years ago

itbra commented 10 years ago

Would you mind to allow users for customization of 'height animation' , 'auto cycling' being toggled on/off and speed and such things? This was way more user friendly. If this is possible. Please add documentation how to pass these in.

noreiller commented 10 years ago

Since I just add some enhancement to the native carousel, I don't modify the cycling and interval options. What do you mean with the height animation, would you prefer a "no animate" option ?

itbra commented 10 years ago

Yes, i don't like the prev/next toggles jumping around while the slide is getting fit. This looks like a "try to hit me - game" and is no good for users wanting to click through. In fact i don't like the jumping around effect at all elements at all. This animation should be configurable by the user as some like it and others don't. I personally perfer the smooth behavior and suggest to hide the prev/next toggles while fitting the slide and fade them in again right when the caption is sliding in.

noreiller commented 10 years ago

So you should bind "slide" and "slid" events to show/hide the controls. Or set the "top" CSS property to a fixed position.

itbra commented 10 years ago

In fact this is exactly how i solved the problem ... for me. But like i said in my comment regarding compressed files, think of your users as non-developers. Providing a well documented configuration object is way more user friendly. Things you might find useful and chíc might not appear to be like that to your users. Searching a plugin makes the user expect to get a configurable extension not requiring it to code any additional stuff like event handlers oneself. In fact it is expected behavior from other well coded plugins to download the file, link the files in the document, attach to the target element like $('#myCarousel').carousel({ autoRotate : false, showCaption : true, jumpAround : false, rotationSpeed : 1000, pauseOn : hover, endlessLoop : false // hide prev/next when first/last item is active }); and be happy. Wouldn't you aggree?

noreiller commented 10 years ago

That's not the purpose of my "plugin". I wrote the different scripts in order to extend the native modal and carousel components with no harm towards their features and options. For end users who need more magic, I can provide some examples with custom scripts but I won't provide more options than the current ones.

itbra commented 10 years ago

I'm not talking about extending the native modal. Instead i am talking about a way to customize YOUR plugin by passing in configuration options. The code above is only an example. The parameters in it are only fictive. But in fact your plugin could be customized via options to allow for animation on/off, anymation type shake/explode/sream/whatever, caption on/off and so on. Presently you already allow to pass parameters through data-attributes, why not through an options object allowing for more parameters than only these?

carousel-fit carousel-caption-active

noreiller commented 10 years ago

In the new docs, I added a section with some advanced examples. If you need more of them, please tell me what you need and I'll add them.

itbra commented 10 years ago

thanks for your effort