noreiller / bootstrap-modal-carousel

A set of plugins to display a carousel into a fullscreen modal box
http://noreiller.github.com/bootstrap-modal-carousel
MIT License
128 stars 63 forks source link

Add compressed script #7

Closed itbra closed 10 years ago

itbra commented 10 years ago

Hi, would you mind to add your script files merged, compressed and minified into 1 file so one can use the separate files for debugging and the single file for production please?

noreiller commented 10 years ago

I could add a minified version, but I was thinking it would a better practice you minify the scripts by yourself since you should concat all the scripts you use on your page. See Grunt (http://gruntjs.com/) for example.

itbra commented 10 years ago

Better practise? Mate, you share a plugin to end users not developers. Think of your end users as non-developers who don't know what a compressor is and who don't wanna study gruntjs nor want to install additional technique (node.js) to get your script compressed. They wanna download and use this thing! Most of the plugins available out there (at least the good ones) provide good documentation, customization through an options object, uncompressed files for debugging and compressed files for production. If you have that infrastructure (node.js, grunt.js) available, do your users a favour and provide them compressed scripts too (same for the stylesheets). I can't believe you said this.

noreiller commented 10 years ago

Ok, I understand. I'll add them.

itbra commented 10 years ago

Good decision! Thank you!

noreiller commented 10 years ago

Do you think I should provide a minified version of the script and styles individually, or only for the full package ?

itbra commented 10 years ago

Typically a repo contains a production/compressed section and a development/uncompressed section. While the latter serves all script files separately the first serves all scripts/styles merged and minified into one script each. I would suggest to deploy the compressed/minified package of your plugin through the "Download Zip". If somebody requires the development version (uncompressed files), he can get them via git clone. This is how i found other git members deploy their stuff.

noreiller commented 10 years ago

You'll find the minified assets in the dist folder.

itbra commented 10 years ago

thanks for your effort