OSD panel switch uses incorrect ranges for second panel

[GoogleCodeExporter]

Reopened as still present in new version:

The code below in OSD_Panels.ino is strange/buggy.  The OSD panel switch 
channel has to be tweaked to get the second panel.

//Second panel
        else if (ch_raw >= 1233 && ch_raw <= 1467 && panel != 1) { //second panel
          osd_clear = 1;
          //osd.clear();
          panel = 1;
        }

It should read something like
        else if (ch_raw >= 1233 && ch_raw <= 1667 && panel != 1) { //second

Original issue reported on code.google.com by pwbec...@hotmail.com on 29 Nov 2014 at 4:44

[GoogleCodeExporter]

Hello,

Please explain in detail.

Why do you think it is a atrange/bugy?

Original comment by gabek...@gmail.com on 29 Nov 2014 at 5:03

[GoogleCodeExporter]

Because 1500, which one would expect to be the middle setting/second panel, 
does not fall in the range ch_raw >= 1233 && ch_raw <= 1467

Original comment by pwbec...@hotmail.com on 30 Nov 2014 at 5:54

[GoogleCodeExporter]

I think i see your point now.

It is not simetric, because this way you can use the same channel for 
additional functions. Like i have used it for mission reset. (Two functions on 
one channel)

I hope it explains it.

Gábor

Original comment by gabek...@gmail.com on 30 Nov 2014 at 10:19

[GoogleCodeExporter]

Original comment by gabek...@gmail.com on 30 Nov 2014 at 10:40

• Added labels: Priority-Low, Type-Other
• Removed labels: Priority-Medium, Type-Defect

[GoogleCodeExporter]

Yes, I understand.  Clever!  It was just confusing because the default setup of 
a switch (1500 middle position) results in the second panel 'not working'.  

Perhaps this could be made explicit by adding some text in the Config tool 
screen.

Original comment by pwbec...@hotmail.com on 3 Dec 2014 at 6:34

[GoogleCodeExporter]

Original comment by gabek...@gmail.com on 4 Dec 2014 at 7:00

• Changed state: Done