Github Ribbon Reponsiveness

[qwo]

Its made out of CSS but when resized it behaves strangely

[jalbertbowden]

.....be more specific.... i reckon the first image is the broken link what should it do? stay the same?

[tjwebb]

I agree with @jalbertbowden. I don't see a problem here.

[qwo]

the fork me banner should extend ACROSS the page, i guess in a correct experience?

As you can see, the resized responsive banner only covers a fixed ratio of the left-right span so its inconsistent.

[jalbertbowden]

no i saw the problem, and you've now clarified it, but i still have no idea what the fix is so it covers 100%....and the text is centered? the box-shadows are/n't still there?

this is like...stacktrace or gtfo for feature requests: so what should the minimized ribbon look like? and at what size? :)

[qwo]

sorry yes so check on this file

https://github.com/norfolkjs/norfolkjs.github.io/blob/master/stylesheets/ribbon.css

it is generated by this project, maybe theres something in the CSS that doesn't handle this case on the main project, and could be a bug on that because it doesn't generate responsive ribbons.

http://codepo8.github.io/css-fork-on-github-ribbon/

Let me know what you find but its definitely i think is a bug when it hits <768px and the ribbon only covers 1/3rd the page fixed.

[tjwebb]

http://codepo8.github.io/css-fork-on-github-ribbon. resize that page to be narrow, and you get the same result.

If we think it's a bug, we should file here: https://github.com/codepo8/css-fork-on-github-ribbon/issues?state=open. Although I'm not convinced it's necessarily a bug, except it's silly that it's on the left side of the screen instead of the right.

[qwo]

I agree it's actually a bug with the project. I showed this to lookmai and she assures me the correct css is not there.

Will be a cool contribution to this web project and a way to fix our own banner :)

On Tuesday, July 15, 2014, Travis Webb notifications@github.com wrote:

http://codepo8.github.io/css-fork-on-github-ribbon. resize that page to be narrow, and you get the same result. If you think it's a bug, it should be filed here: https://github.com/codepo8/css-fork-on-github-ribbon/issues?state=open.

— Reply to this email directly or view it on GitHub https://github.com/norfolkjs/norfolkjs.github.io/issues/68#issuecomment-49077681 .

Stanley Zheng @stanzheng http://twitter.com/stanzheng

[tjwebb]

Yea. Incidentally, their fork button doesn't actually work for me.

[jalbertbowden]

good call travis. i never read the intro. it is what it is.

[qwo]

@tjwebb you mean the one on their project or the one on norfolkjs?

i mean heres the issue repo, i think i posted it, https://github.com/codepo8/css-fork-on-github-ribbon/# but it does look it isn't mega popular are hasn't been updated in a while.

Two fixes.

1. Update and fix their project
2. Switch to an image icon.

Im ok with either one.

[tjwebb]

The things you mentioned have already been covered in this thread.

1.

http://codepo8.github.io/css-fork-on-github-ribbon. resize that page to be narrow, and you get the same result.

@tjwebb you mean the one on their project or the one on norfolkjs?

2.

If we think it's a bug, we should file here: https://github.com/codepo8/css-fork-on-github-ribbon/issues?state=open.

i mean heres the issue repo, i think i posted it ... Two fixes.

1. Update and fix their project

[tjwebb]

This issue became really bureaucratic somehow. If someone wants to fix their bug, I say go for it, and reference this issue so we can track it. If they say its not a bug, we can fork them or ignore it.

[jalbertbowden]

+1 for hidden bureacracies

[metaskills]

FWIW, I really dislike the "Fork Me" message. It assumes a destination action when in most cases I think people just want to "View The Source" or "Create An Issue" or "Just Learn".

[lynnaloo]

I think our intent is a way for them to view the source, although Ken's idea of viewing the whole org is a better idea. I'm OK with ditching "fork me" for a more descriptive link.