search

norgepaul / TChromeTabs

Comprehensive Delphi implementation of Chrome's tab system
Other
215 stars 78 forks source link

Memory leak fix (dragging from one TChromeTabs to another TChromeTabs) #47

Closed delphiripper closed 8 years ago

delphiripper commented 8 years ago

Line 3644 in ChromeTabs.pas sets FDragTabControl to nil just before it should/would have been destroyed. This creates a memory leak while dragging a tab from one TChromeTabs to another TChromeTabs.

Easy fix: Delete line 3644

(This is my very first pull request, ever, so let me know if I am doing it wrong)

delphiripper commented 8 years ago

Merged... Cool - My first contribution :-) BTW I really like your ChromeTab control :-) I do a lot of GUI work myself and a lot of "Photoshopping", so I really appreciate when someone makes something pretty and/or cool - and you did both ;-)

norgepaul commented 8 years ago

Thanks for the fix and the nice words :)

Cheers, Paul

On 11 December 2015 at 22:00, delphiripper notifications@github.com wrote:

Merged... Cool - My first contribution :-) BTW I really like your ChromeTab control :-) I do a lot of GUI work myself and a lot of "Photoshopping", so I really appreciate when someone makes something pretty and/or cool - and you did both ;-)

— Reply to this email directly or view it on GitHub https://github.com/norgepaul/TChromeTabs/pull/47#issuecomment-164046324.