norgepaul / TChromeTabs

Comprehensive Delphi implementation of Chrome's tab system
Other
215 stars 78 forks source link

bug(spell error?) in TChromeTabControl.CalculateRects #58

Closed mksjgj closed 3 years ago

mksjgj commented 7 years ago

if OverlayImageVisible then begin if ChromeTabs.GetImagesOverlay.Width > ChromeTabs.GetImagesOverlay.Width then ImageWidth := ChromeTabs.GetImagesOverlay.Width;

if ChromeTabs.GetImagesOverlay.Height > ChromeTabs.GetImagesOverlay.Height then
  ImageHeight := ChromeTabs.GetImagesOverlay.Height;

end;

i think it should be:

if OverlayImageVisible then begin if ChromeTabs.GetImagesOverlay.Width > ChromeTabs.GetImages.Width then ImageWidth := ChromeTabs.GetImagesOverlay.Width;

if ChromeTabs.GetImagesOverlay.Height > ChromeTabs.**GetImages**.Height then
  ImageHeight := ChromeTabs.GetImagesOverlay.Height;

end;

mksjgj commented 7 years ago

a better way:

if OverlayImageVisible then begin if ChromeTabs.GetImagesOverlay.Width > ImageWidth then ImageWidth := ChromeTabs.GetImagesOverlay.Width;

if ChromeTabs.GetImagesOverlay.Height > ImageHeight then ImageHeight := ChromeTabs.GetImagesOverlay.Height;

end;

landrix commented 3 years ago

fixed in next release

currently here

https://github.com/norgepaul/TChromeTabs/tree/monitorv2support