Closed PetrDlouhy closed 1 year ago
Does #225 resolve this?
@Andrew-Chen-Wang Seems yes. Seems like this might be the test needed in that PR.
There is probably only last issue unsolved for this PR - the filebased
sqlite3
tests got broken for some reason after introducing the new admin_tests
app.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
cachalot/init.py | 1 | 83.33% | ||
cachalot/utils.py | 2 | 92.12% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 2937621086: | -0.2% |
Covered Lines: | 709 |
Relevant Lines: | 731 |
Totals | |
---|---|
Change from base Build 2937621086: | 0.1% |
Covered Lines: | 694 |
Relevant Lines: | 713 |
@Andrew-Chen-Wang Seems like rebasing onto commits from #225 fix both the tests that were supposed to fail without fix and those that got broken by introducing new app. Now it should be ready.
lgtm, looks like adding #225 worked like a charm. Will merge this at home and make a new release. Thanks for adding tests!
Description
For now this only adds test for error #226. Should work in Django 4.0 and fail in 4.1.
Rationale
To be able to fix #226 and not introduce that error again.