noripyt / django-cachalot

No effort, no worry, maximum performance.
http://django-cachalot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.23k stars 151 forks source link

add test that will cause error #226 #227

Closed PetrDlouhy closed 1 year ago

PetrDlouhy commented 1 year ago

Description

For now this only adds test for error #226. Should work in Django 4.0 and fail in 4.1.

Rationale

To be able to fix #226 and not introduce that error again.

Andrew-Chen-Wang commented 1 year ago

Does #225 resolve this?

PetrDlouhy commented 1 year ago

@Andrew-Chen-Wang Seems yes. Seems like this might be the test needed in that PR. There is probably only last issue unsolved for this PR - the filebased sqlite3 tests got broken for some reason after introducing the new admin_tests app.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4389438568


Files with Coverage Reduction New Missed Lines %
cachalot/init.py 1 83.33%
cachalot/utils.py 2 92.12%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 2937621086: -0.2%
Covered Lines: 709
Relevant Lines: 731

💛 - Coveralls
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4389438568


Totals Coverage Status
Change from base Build 2937621086: 0.1%
Covered Lines: 694
Relevant Lines: 713

💛 - Coveralls
PetrDlouhy commented 1 year ago

@Andrew-Chen-Wang Seems like rebasing onto commits from #225 fix both the tests that were supposed to fail without fix and those that got broken by introducing new app. Now it should be ready.

Andrew-Chen-Wang commented 1 year ago

lgtm, looks like adding #225 worked like a charm. Will merge this at home and make a new release. Thanks for adding tests!