search

noris-network / ansible-prometheus-kafka-adapter

Ansible role to deploy prometheus-kafka-adapter as a Docker container
Apache License 2.0
0 stars 0 forks source link

docker kill and docker rm beautification #20

Open linwalth opened 1 year ago

linwalth commented 1 year ago

https://github.com/noris-network/ansible-prometheus-kafka-adapter/blob/master/templates/prometheus-kafka-adapter.service.j2#L11

the docker kill pre-exec did not work on my machine. docker rm -f did.

docker rm -f saves the kill step and reduces the number of pre-exec tasks.

rm -f also implies kill signal already. (https://docs.docker.com/engine/reference/commandline/rm/)

fbermel commented 1 year ago

I've opened a PR for this https://github.com/noris-network/ansible-prometheus-kafka-adapter/pull/21