noritada / grib-rs

GRIB format parser for Rust
Apache License 2.0
56 stars 9 forks source link

Fix Clippy lints and add to CI #6

Closed mulimoen closed 3 years ago

mulimoen commented 3 years ago

This PR consists mostly of fixes for clippy lints to make the code a bit more rusty.

Two other larger changes are in the GribInt trait and postfix on CliError to comply with the clippy lints.

This PR also fixes a bug with potentially unused IO which could cause issues in the future.

mulimoen commented 3 years ago

The build failure on windows was fixed upstreams, which makes CI green for all platforms

noritada commented 3 years ago

Thank you very much for many cleanups!! I will review it.