search

norkunas / onesignal-php-api

OneSignal API for PHP
MIT License
233 stars 82 forks source link

Url validation and deeplinks #33

Closed dpgover closed 8 years ago

dpgover commented 8 years ago

The url validation format does not allow for custom deeplink protocols. I think the restriction for http/https should be removed.

Is that intended?

Cheers!

norkunas commented 8 years ago

Hello @dpgover, Check #34, do you think this would be better?

dpgover commented 8 years ago

34 is perfect, as validate_url doesn't care about the protocol.

Thanks!

dpgover commented 8 years ago

Can you merge this to v0.1.5 or make a v0.1.6 release?

Thanks!!

norkunas commented 8 years ago

@dpgover v0.1.6 is now released.

dpgover commented 8 years ago

:+1: :+1: :+1:

Thanks!!!!