search

norkunas / onesignal-php-api

OneSignal API for PHP
MIT License
233 stars 82 forks source link

Fixed some non-working things #44

Closed jachus closed 7 years ago

norkunas commented 7 years ago

@jachus thanks for PR. What's the reason for moving 'app_id' => $this->api->getConfig()->getApplicationId() to the URL part?

jachus commented 7 years ago

Hello! app_id is a GET parameter, by the documentation: https://documentation.onesignal.com/docs/players-view-devices

norkunas commented 7 years ago

Hello @jachus, yes I know about that, but it worked for me also when i sent requests with app id in request body. But ok we should use this like documentation states. Could you open a new PR for this? Because this should be fixed also in notifications endpoints.

Also what's with 'offset' => filter_var($offset, FILTER_VALIDATE_INT) ? filter_var could return false now, so i don't understand this change.