Closed tixastronauta closed 7 years ago
@tixastronauta constructor in 0.1 doesn't changed and it instantiates guzzle as before you don't inject it
@norkunas from my understanding that is not the case.
public function __construct(Config $config = null, Client $client = null)
{
$this->config = ($config ?: new Config());
$this->client = ($client ?: new Client([
'defaults' => [
'headers' => [
'Accept' => 'application/json',
],
],
]));
}
public function __construct(Config $config = null, Client $client = null)
{
$this->config = ($config ?: new Config());
if (null !== $client) {
$this->client = $client;
}
}
@tixastronauta sorry, master was target in release. should be good now.
Awesome @norkunas 👍 ! Thank you!
Release
v.0.1.11
should be a major release as it introduces a bc-break.My previously working code, now crashes because I'm not injecting a
Client
intoOneSignal
constructor. Inv.0.1.10
there was no need to inject aClient
because a new Guzzle Client was instantiated.