search

norkunas / onesignal-php-api

OneSignal API for PHP
MIT License
233 stars 82 forks source link

Fixed csvExport method #57

Closed tixastronauta closed 7 years ago

tixastronauta commented 7 years ago

Method csvExport got broken on v0.1.10. It was working fine on v0.1.9.

norkunas commented 7 years ago

@tixastronauta you should fix only the URL and leave app_id as a query parameter. anyway thanks

norkunas commented 7 years ago

@tixastronauta Will you finish this?

tixastronauta commented 7 years ago

Sorry @norkunas I will only be back on Monday. But from what I can tell, my PR is according to the documentation: https://documentation.onesignal.com/reference#csv-export

App ID is a header, not a query string.

norkunas commented 7 years ago

I talked with support and they said that both choices are supported so for consistency I've moved to query string.

2016-12-02 20:59 "tixastronauta" notifications@github.com rašė:

Sorry @norkunas https://github.com/norkunas I will only be back on Monday. But from what I can tell, my PR is according to the documentation: https://documentation.onesignal.com/reference#csv-export

App ID is a header, not a query string.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/norkunas/onesignal-php-api/pull/57#issuecomment-264533767, or mute the thread https://github.com/notifications/unsubscribe-auth/ACmMOFQbYmxu2z4vhu059JtVgAb8RN5mks5rEGp7gaJpZM4LAGpA .

tixastronauta commented 7 years ago

@norkunas done 😄

norkunas commented 7 years ago

@tixastronauta thanks!