search

norkunas / onesignal-php-api

OneSignal API for PHP
MIT License
233 stars 82 forks source link

Missing 'android_gcm_sender_id' in AppResolver.php #94

Closed rcerljenko closed 5 years ago

rcerljenko commented 5 years ago

Missing field for creating/updating app config (type: string): android_gcm_sender_id - Your Google Project number. Also know as Sender ID.

Solution:

->setDefined('android_gcm_sender_id')
->setAllowedTypes('android_gcm_sender_id', 'string')

Documentation: https://documentation.onesignal.com/reference#create-an-app

norkunas commented 5 years ago

Hello, you could submit a PR

rcerljenko commented 5 years ago

Will composer automatically update new version?

From: Tomas Norkūnas notifications@github.com Sent: Tuesday, August 28, 2018 2:06:07 PM To: norkunas/onesignal-php-api Cc: Ricardo Čerljenko; Author Subject: Re: [norkunas/onesignal-php-api] Missing 'android_gcm_sender_id' in AppResolver.php (#94)

Closed #94https://github.com/norkunas/onesignal-php-api/issues/94.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/norkunas/onesignal-php-api/issues/94#event-1812888102, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AP_EyBycrS56lErAP21Fcnbx80F0fotlks5uVTIvgaJpZM4WNzX8.

norkunas commented 5 years ago

Yes, it should. I've made a new release, unless you strictly provided which version for composer to use

rcerljenko commented 5 years ago

Supercool. Thanks!

From: Tomas Norkūnas notifications@github.com Sent: Tuesday, August 28, 2018 2:54:29 PM To: norkunas/onesignal-php-api Cc: Ricardo Čerljenko; Author Subject: Re: [norkunas/onesignal-php-api] Missing 'android_gcm_sender_id' in AppResolver.php (#94)

Yes, it should. I've made a new release

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/norkunas/onesignal-php-api/issues/94#issuecomment-416573129, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AP_EyPtueXB8lkv0gVs_PyP0VeiEjgrQks5uVT2FgaJpZM4WNzX8.