search

norkunas / onesignal-php-api

OneSignal API for PHP
MIT License
234 stars 83 forks source link

fixed AppResolver by adding 'android_gcm_sender_id' #96

Closed rcerljenko closed 6 years ago

rcerljenko commented 6 years ago

Missing field for creating/updating app config: android_gcm_sender_id - (string) Your Google Project number. Also know as Sender ID.

norkunas commented 6 years ago

Please change to 1.0 target branch

rcerljenko commented 6 years ago

here you go :)

norkunas commented 6 years ago

Please rebase with 1.0, because there are many unrelated commits :)

rcerljenko commented 6 years ago

Hi,

Added new pull request with 1.0 branch.

Best regards,

Ricardo

From: Tomas Norkūnas notifications@github.com Sent: Tuesday, August 28, 2018 11:11:21 AM To: norkunas/onesignal-php-api Cc: Ricardo Čerljenko; Author Subject: Re: [norkunas/onesignal-php-api] fixed AppResolver by adding 'android_gcm_sender_id' (#96)

Please rebase with 1.0, because there are many unrelated commits :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/norkunas/onesignal-php-api/pull/96#issuecomment-416510049, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AP_EyC7xyS3t8uMZDDpKpAsjF_itSc6Eks5uVQk5gaJpZM4WO7i5.