search

norlab-ulaval / libnabo

A fast K Nearest Neighbor library for low-dimensional spaces
http://norlab-ulaval.github.io/libnabo/
BSD 3-Clause "New" or "Revised" License
431 stars 142 forks source link

Automaticaly find eigen3 #110

Closed maximecharriere closed 3 years ago

maximecharriere commented 3 years ago

Now we have to set the CMake variable EIGEN_INCLUDE_DIR manually when installing libnabo on Windows.
It would be simpler to use the environment variable EIGEN3_INC_DIR added when installing Eigen.

To make this changes, I was inspired by the FindEigen3.cmake file from CGAL.
I didn't take the whole file which is very complete and secure, but only the part that find Eigen path.

I was not able to test these modifications on Linux. So it should be done before merge.

ethzasl-jenkins commented 3 years ago

Can one of the admins verify this patch?

pomerlef commented 3 years ago

ok to test

pomerlef commented 3 years ago

I'll merge it tomorrow unless someone has more comments.