norlab-ulaval / libnabo

A fast K Nearest Neighbor library for low-dimensional spaces
http://norlab-ulaval.github.io/libnabo/
BSD 3-Clause "New" or "Revised" License
431 stars 142 forks source link

CMake and assert fixes #129

Closed gsm-mgv closed 6 months ago

gsm-mgv commented 6 months ago

The default nabo cmake is overriding the c++ standard to use (to C++11), instead of using that specified by an external project or via the CLI. This is a problem when using newer versions of Eigen, that rely on C++14 or higher.

Current resolution includes a check to make sure the CXX_STANDARD has not been set, and if it has not, it is configured to be C++14 (bumped from 11).

Also included some minor fixes around assertions with newer compilers (eg. On Fedora39 with GCC13).