norlab-ulaval / libnabo

A fast K Nearest Neighbor library for low-dimensional spaces
http://norlab-ulaval.github.io/libnabo/
BSD 3-Clause "New" or "Revised" License
431 stars 142 forks source link

Implement linabo-build-system #130

Closed RedLeader962 closed 5 months ago

RedLeader962 commented 6 months ago

Description

Summary:

Add norlab-build-system library support. libnabo now have a build infrastructure agnostic build system which can be run on continuous integration infrastructure such as github-action or TeamCity Continuous Integration server. It can also be run localy to improve developement workflow. It support multi-architecture and multi-os version build. There is also new installer script for ubuntu

Changes and type of changes (quick overview):


Checklist:

Code related

PR creation related

PR description related


RedLeader962 commented 6 months ago

@boxanm For tag mention in bats tests, we can't change references to the latest release tag (1.0.7) as there is test logic that require fetching an actual released version. For bash script, the one mentioned in libnabo_installer.bash header documentation is there just as an examples of the proper pattern to pass as argument. The two places where we need to bump the version number (ie package.xml and nabo.h) will be modified at the final release step.

Thanks for spotting the last sneaky libpointmatcher from the codebase, I've renamed it to test_dotenv_libnabo.bats.

RedLeader962 commented 6 months ago

I've also made minor style change in Dockerfile.libnabo.integration_test and docker-compose.libnabo.yaml so that it be intuitive i.e. change .*compilation_test.* to .*integration_test*

I'll push the commit tonight