Fixed regression introduced with af3b638bc2a3 concerning installed libnaboConfig.cmake

norlab-ulaval / libnabo

A fast K Nearest Neighbor library for low-dimensional spaces

http://norlab-ulaval.github.io/libnabo/

BSD 3-Clause "New" or "Revised" License

440 stars 144 forks source link

Fixed regression introduced with af3b638bc2a3 concerning installed libnaboConfig.cmake #65

Closed HannesSommer closed 7 years ago

HannesSommer commented 7 years ago

The installed file need to be pre generated. The pure library name will not work with static archives in catkin workspaces.

Problematic change was: https://github.com/ethz-asl/libnabo/pull/57/files#diff-af3b638bc2a3e6c650974192a53c7291L174

HannesSommer commented 7 years ago

I'm merging this because the current master it is breaking a lot of builds right now. This might not be perfect but should at least be an improvement.

davidlandry93 commented 7 years ago

This patch maintains Arch Linux compatibility on my machine. Sorry about the mess, and thanks a lot for the feedback!

HannesSommer commented 7 years ago

@davidlandry93 , thanks for the testing! No problem. We have to thank for your contribution. Great that it still works :).