search

norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.63k stars 549 forks source link

Min/max datafilters are confusing to use #31

Closed pomerlef closed 6 years ago

pomerlef commented 10 years ago

The documentation seems to confuse greater than and smaller than: https://github.com/ethz-asl/libpointmatcher/blob/master/doc/Datafilters.md#maximum-distance-filter-

Those filter should be combined and a parameter should be added to select whether we want to keep point smaller or greater than a threshold.

simonpierredeschenes commented 6 years ago

https://github.com/ethz-asl/libpointmatcher/pull/270 This pull request introduces the new DistanceLimitDataPointsFilter to replace both min and max distance filters.