Fixes for windows - Githubissues

norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics

BSD 3-Clause "New" or "Revised" License

1.58k stars 542 forks source link

Fixes for windows #437

Closed maxGimeno closed 3 years ago

maxGimeno commented 3 years ago

Fixes the pthread dependency as discussed in #428
Fixes the boost dependency declaration in libpointmatcherConfig.cmake.in so the users won't have to declare it in their project.

I also have a bug, that says that yaml-cpp-pm-targets.cmake cannot be found, and I have to manually copy it from /build/contrib/yaml-cpp-pm/CMakeFiles/Export/share/libpointmatcher/cmake/ to ./build but I couldn't find how to fix it.

Fixes #435

ethzasl-jenkins commented 3 years ago

Can one of the admins verify this patch?

pomerlef commented 3 years ago

ok to test

pomerlef commented 3 years ago

Thanks for the PR!

@peci1 anything breaking on your side before I merge?

peci1 commented 3 years ago

Thanks for asking, this looks harmless ;)