search

norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.58k stars 542 forks source link

catkin not required for pure cmake packages #482

Closed Timple closed 2 years ago

Timple commented 2 years ago

This prevens rosdep resolving in ROS2

ethzasl-jenkins commented 2 years ago

Can one of the admins verify this patch?

pomerlef commented 2 years ago

ok to test

pomerlef commented 2 years ago

@simonpierredeschenes can you check if this patch will break default ROS1 installs ?

simonpierredeschenes commented 2 years ago

I'll have a look

Timple commented 2 years ago

For what it's worth: it has beendone before for pure cmake packages :slightly_smiling_face: https://github.com/nobleo/paho.mqtt.c-release/blob/master/patches/package.xml