search

norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.61k stars 544 forks source link

Create LICENSE file based on BSD license as per package.xml #485

Closed Timple closed 2 years ago

Timple commented 2 years ago

Same as https://github.com/ethz-asl/libnabo/pull/118

ethzasl-jenkins commented 2 years ago

Can one of the admins verify this patch?

pomerlef commented 2 years ago

There is a duplicate commit from #482. Please update the PR.

Timple commented 2 years ago

I was under the assumption these commits dropped out upon merging the other PR.

But I updated the PR to a single commit :+1:

stephanemagnenat commented 2 years ago

The license is wrong, the copyright is clearly not 2021 ASL, as Libpointmatcher was created far earlier and people from other institutions have also contributed. The best would be a date range and something like "the Libpointmatcher authors" regarding who owns the copyright.

pomerlef commented 2 years ago

I'm fine with the changes, but the branch is still out-of-date with master

Timple commented 2 years ago

Out of date how?

It only contains the three commits for the license. Or would you like me to rebase onto master?

pomerlef commented 2 years ago

ok to test