search

norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.61k stars 544 forks source link

Loop counter variable used twice #489

Closed simonpierredeschenes closed 12 months ago

simonpierredeschenes commented 2 years ago

The variable i is used as a counter in both the outer and inner loops.

https://github.com/ethz-asl/libpointmatcher/blob/c0d13ea87d3f6ccb81cbf0f9dc02a118a0c42f03/pointmatcher/DataPointsFilters/SurfaceNormal.cpp#L205

harsh-su commented 1 year ago

Hii Simon, Can I work on this issue?

simonpierredeschenes commented 1 year ago

Hi @HS7499 , yes you can work on it, it would be very appreciated! You can assign me to review the PR when you create it. Thanks! :)

pomerlef commented 12 months ago

Solved with #521