search

norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.58k stars 542 forks source link

Fix/move icp tests to separate folder #509

Closed YoshuaNava closed 1 year ago

YoshuaNava commented 1 year ago

Description

This PR separates the main file for libpointmatcher's unit tests (utest.cpp), from the existing ICP tests. The motivation being that, I have more ICP tests in implementation stage, and I see the potential to cover more facets of the algorithm.

Tests

All succeeding locally.

Instructions

I tested this locally with a ROS1 catkin build, by

  1. Cloning libpointmatcher into a catkin workspace, along with the latest version of libnabo
  2. Building with catkin build -DBUILD_TESTS=Enabled
  3. Executing the tests from the catkin workspace folder with $ ./build/libpointmatcher/utest/utest --path <path_to_workspace>/src/libpointmatcher/examples/data/
pomerlef commented 1 year ago

Add to whitelist

YoshuaNava commented 1 year ago

Hi @pomerlef, There is a message saying that all checks have failed, but no tests were run:

image

What could be the issue? I also see it in https://github.com/ethz-asl/libpointmatcher/pull/508

YoshuaNava commented 1 year ago

Hi @pomerlef, Sorry to bother. I wanted to catch up on the status of this MR, and your thoughts on it.

Thank you in advance :pray:

YoshuaNava commented 1 year ago

Thank you!

About the pipeline, it doesn't seem to be running atm:

image

Is there any way I could trigger it?

pomerlef commented 1 year ago

The CI tool setup by ASL seems out of order. I need to set up a local machine to validate the modification. Once it is done, I'll start processing the PRs.

YoshuaNava commented 1 year ago

Oki :+1:

pomerlef commented 1 year ago

This was manually merged into master.