search

norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.61k stars 544 forks source link

Handle libnabo config mode #513

Closed sloriot closed 1 year ago

sloriot commented 1 year ago

An alternative would be to set libnabo_INCLUDE_DIRS and libnabo_LIBRARIES in libnabo-targets.cmake

ethzasl-jenkins commented 1 year ago

Can one of the admins verify this patch?

pomerlef commented 1 year ago

ok to test

pomerlef commented 1 year ago

@sloriot I'm missing the intent of the PR. Can you describe what was not working or what you want to improve?

sloriot commented 1 year ago

I wanted to have the config mode of cmake working with libnabo. Indeed, if you use the config mode then libnabo will be reported as found but the cmake variables that pointmatcher expects are not set.

As a side note, I also noticed that it is not possible to use pointmatcher with cmake without doing make install which does not seems to be ideal for people without root access to their computer. Last point, I don't understand why libnabo is not part of the dependency libs of pointmatcher target like you did with boost. I hacked it with https://github.com/CGAL/cgal/pull/7498 but if you are interested in getting some cmake update I can submit another PR to address both issues.

pomerlef commented 1 year ago

Any link with #514? and of course, if you want to propose another PR we will gladly review it!

sloriot commented 1 year ago

Any link with #514? and of course, if you want to propose another PR we will gladly review it!

It indeed seems to be the same issue that my hack fixes at CGAL level. Since there was no such error in the past, I guess that some libnabo API is now exposed in pointmatcher (thus the need for the link).

pomerlef commented 1 year ago

Thanks @sloriot !