norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.58k stars 542 forks source link

fix: Issue 534 transformation tests failing on some platforms #559

Closed boxanm closed 5 months ago

boxanm commented 5 months ago

Description

Summary:

The 3D Transformation utests were failing on Ubuntu Bionic with Eigen 3.3.4, in contrast to all other platforms tested with Eigen 3.4. I added a non-zero epsilon precision value to Eigen's isApprox call for Rotation and Rotation+Scaling tests. My guess is the two versions of Eigen treat zero epsilon precision values differently; hence the tests weren't failing with 3.4.0. Fixes https://github.com/norlab-ulaval/libpointmatcher/issues/534

Changes and type of changes (quick overview):

Checklist:

Code related

PR creation related

PR description related


Note for repository admins

Release PR related

sonarcloud[bot] commented 5 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

20.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

boxanm commented 5 months ago

The arm64 build randomly falls on the build farm. Since this issue wasn't encountered locally on an arm machine, we assume it was due to the CPU architecture virtualization. I'm therefore bypassing the branch protections.