Closed boxanm closed 5 months ago
The arm64 build randomly falls on the build farm. Since this issue wasn't encountered locally on an arm machine, we assume it was due to the CPU architecture virtualization. I'm therefore bypassing the branch protections.
Description
Summary:
The 3D Transformation utests were failing on Ubuntu Bionic with Eigen 3.3.4, in contrast to all other platforms tested with Eigen 3.4. I added a non-zero epsilon precision value to Eigen's
isApprox
call for Rotation and Rotation+Scaling tests. My guess is the two versions of Eigen treat zero epsilon precision values differently; hence the tests weren't failing with 3.4.0. Fixes https://github.com/norlab-ulaval/libpointmatcher/issues/534Changes and type of changes (quick overview):
isApprox
in failing Transformation utest.Checklist:
Code related
PR creation related
base ref
branch is set to thedevelop
branch (the build-system won't be triggered otherwise)develop
branch (the build-system will reject it otherwise)PR description related
# <issue-id>
if changes are of typefix
feat
fix
docs
style
refactor
perf
test
build
ci
chore
revert
<type>!
Note for repository admins
Release PR related
push/merge
on the default branch (ie:master
) and therelease
branch.draft
mode until all the release reviewers are ready to push the release.release
->master
branch is created (not in draft mode),