norlab-ulaval / libpointmatcher

An Iterative Closest Point (ICP) library for 2D and 3D mapping in Robotics
BSD 3-Clause "New" or "Revised" License
1.61k stars 544 forks source link

Installation problem #7

Closed oleg-alexandrov closed 11 years ago

oleg-alexandrov commented 11 years ago

When libpointmatcher is installed, it fails to copy the file Bibliography.h. Solution: Add this to CMakeLists.txt.

stephanemagnenat commented 11 years ago

Yes, Bibliography.h is a private header that is not installed, why do you need it?

oleg-alexandrov commented 11 years ago

Bibliography.h is being used in the examples, such as examples/icp.cpp

Now, it is possible to edit examples/icp.cpp, more specifically the function validateArgs() to remove the call to listModules(), and in turn, one can comment out altogether this listModules() function which uses the Bibliography stuff. Then, the example will compile.

That is to say, you are right, Bibliography.h is not strictly necessary to use libpointmatcher. It is somewhat confusing however that your own examples won't compile without it.

oleg-alexandrov commented 11 years ago

This is a minor thing, so I am closing it. Bibliography.h could even go in the examples directory as nobody else uses it, but it is fine either way.